Skip to content

Comments

[SPARK-28808][DOCS][SQL] Document SHOW FUNCTIONS in SQL Reference.#25539

Closed
dilipbiswal wants to merge 8 commits intoapache:masterfrom
dilipbiswal:ref-doc-show-functions
Closed

[SPARK-28808][DOCS][SQL] Document SHOW FUNCTIONS in SQL Reference.#25539
dilipbiswal wants to merge 8 commits intoapache:masterfrom
dilipbiswal:ref-doc-show-functions

Conversation

@dilipbiswal
Copy link
Contributor

@dilipbiswal dilipbiswal commented Aug 21, 2019

What changes were proposed in this pull request?

Document SHOW FUNCTIONS statement in SQL Reference Guide.

Why are the changes needed?

Currently Spark lacks documentation on the supported SQL constructs causing
confusion among users who sometimes have to look at the code to understand the
usage. This is aimed at addressing this issue.

Does this PR introduce any user-facing change?

Yes.

Before:

After.
image

Screen Shot 2019-09-04 at 11 41 44 AM

Screen Shot 2019-09-04 at 11 41 54 AM

How was this patch tested?

Tested using jykyll build --serve

@dilipbiswal dilipbiswal changed the title [SPARK-28808] Document SHOW FUNCTIONS in SQL Reference. [SPARK-28808][SQL] Document SHOW FUNCTIONS in SQL Reference. Aug 21, 2019
@SparkQA
Copy link

SparkQA commented Aug 21, 2019

Test build #109499 has finished for PR 25539 at commit b713ad6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dilipbiswal
Copy link
Contributor Author

cc @gatorsmile

@SparkQA
Copy link

SparkQA commented Aug 21, 2019

Test build #109517 has finished for PR 25539 at commit 2088aa5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dilipbiswal dilipbiswal changed the title [SPARK-28808][SQL] Document SHOW FUNCTIONS in SQL Reference. [SPARK-28808][DOC] Document SHOW FUNCTIONS in SQL Reference. Aug 22, 2019
@SparkQA
Copy link

SparkQA commented Aug 23, 2019

Test build #109634 has finished for PR 25539 at commit 39d86b7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dilipbiswal dilipbiswal changed the title [SPARK-28808][DOC] Document SHOW FUNCTIONS in SQL Reference. [SPARK-28808][DOCS][SQL] Document SHOW FUNCTIONS in SQL Reference. Aug 24, 2019
@sharangk
Copy link
Contributor

@dilipbiswal , Should we add the below note?
"LIKE" qualifier is optional and has no relevance. It is allowed only for compatibility purpose.

### Syntax
{% highlight sql %}
SHOW [USER|SYSTEM|ALL] FUNCTIONS ([LIKE] qualified_function_name | regex_pattern)
qualified_function_name:= [db.]function_name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still needed? How about only doing it in the section ### Parameters?

@sharangk
Copy link
Contributor

image

@dilipbiswal dilipbiswal force-pushed the ref-doc-show-functions branch from 39d86b7 to 52033e0 Compare September 3, 2019 21:19
@SparkQA
Copy link

SparkQA commented Sep 3, 2019

Test build #110063 has finished for PR 25539 at commit 52033e0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 3, 2019

Test build #110066 has finished for PR 25539 at commit feab627.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 4, 2019

Test build #110071 has finished for PR 25539 at commit ad07bbb.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member

LGTM

Thanks! Merged to master.

@gatorsmile gatorsmile closed this in f96486b Sep 4, 2019
@dilipbiswal
Copy link
Contributor Author

@gatorsmile Thank you very much.
@sharangk Thank you for your comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants